-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 render thumbnails in CF workers using chart configs from R2 #3847
🔨 render thumbnails in CF workers using chart configs from R2 #3847
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e9eace9
to
9105d37
Compare
5819ecd
to
6e9dc2f
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-06 18:38:04 UTC |
7c43c3d
to
ae06e0b
Compare
7c77d87
to
ff63d5d
Compare
6478da8
to
76d65b2
Compare
799a43f
to
5609c8c
Compare
76d65b2
to
ef42cf3
Compare
5609c8c
to
6c1fec3
Compare
ef42cf3
to
d033124
Compare
6c1fec3
to
36d9326
Compare
d033124
to
69fe865
Compare
36d9326
to
f704dff
Compare
69fe865
to
f8b200f
Compare
f8b200f
to
87f0855
Compare
This PR changes how the CF thumnail worker gets the config for a chart. It used to be the case that it would fetch the HTML file of the grapher page at the given slug and extract the config from that HTML. Now it looks up the grapher config json file in an R2 bucket.
This PR only changes this for published charts accessed by slug. A later PR will enable this also by UUID.
Cloudflare is a bit weird with the intersection of support of various features between CF workers/pages functions, R2 and local/remote dev support: